Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating GH actions to run quarkus cli on windows #1999

Closed
wants to merge 1 commit into from
Closed

Updating GH actions to run quarkus cli on windows #1999

wants to merge 1 commit into from

Conversation

TimonCzech
Copy link

Summary

TODO

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@jedla97
Copy link
Member

jedla97 commented Sep 11, 2024

Let's see if this work. Also this should be added to native win run

@jedla97 jedla97 self-requested a review September 11, 2024 13:04
@jedla97
Copy link
Member

jedla97 commented Sep 11, 2024

I see it's updating only daily, for check it in PR it should be also updated in https://github.com/quarkus-qe/quarkus-test-suite/blob/main/.github/workflows/ci.yml

@TimonCzech TimonCzech force-pushed the windows-cli-test branch 3 times, most recently from dd0ca6e to d2684e2 Compare September 12, 2024 13:22
@jedla97 jedla97 linked an issue Sep 12, 2024 that may be closed by this pull request
Test the latest Quarkus CLI (based on 999-SNAPSHOT) weekly on Windows #1464
Open
@TimonCzech
Copy link
Author

@jedla97 will finish this

@michalvavrik
Copy link
Member

There has been changes in the GH CI, you would need to adapt your PR, make sure that no test is running DEV svc and most importantly, I am not sure that bat will work, will it? I'd think you need .exe. This PR is bit old so if you are interested, please come back to it. It would be great addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedla97 jedla97 Awaiting requested review from jedla97

Assignees
No one assigned
Labels
DON'T MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test the latest Quarkus CLI (based on 999-SNAPSHOT) weekly on Windows
3 participants
@TimonCzech @jedla97 @michalvavrik