From dc140e500bb95fbd9bbe752bdb4c56f905cd802e Mon Sep 17 00:00:00 2001 From: Kaiyue Yang Date: Thu, 11 Jul 2024 08:43:23 -0700 Subject: [PATCH] [TorchCodec] Use correct type for impl_abstract functions (#75) Summary: Pull Request resolved: https://github.com/pytorch-labs/torchcodec/pull/75 All the metadata functions return value are strings not tensors, plus torch.empty_like can't apply to an empty string. Reviewed By: scotts, NicolasHug, ahmadsharif1 Differential Revision: D59609638 fbshipit-source-id: 44d12ba355ae34db8cbe1365f25536f1fa109f2f --- .../decoders/_core/video_decoder_ops.py | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/src/torchcodec/decoders/_core/video_decoder_ops.py b/src/torchcodec/decoders/_core/video_decoder_ops.py index 3e4ef0b1..73b02f51 100644 --- a/src/torchcodec/decoders/_core/video_decoder_ops.py +++ b/src/torchcodec/decoders/_core/video_decoder_ops.py @@ -176,25 +176,23 @@ def get_frames_in_range_abstract( @impl_abstract("torchcodec_ns::get_json_metadata") -def get_json_metadata_abstract(decoder: torch.Tensor) -> torch.Tensor: - return torch.empty_like("") # type: ignore[arg-type] +def get_json_metadata_abstract(decoder: torch.Tensor) -> str: + return "" @impl_abstract("torchcodec_ns::get_container_json_metadata") -def get_container_json_metadata_abstract(decoder: torch.Tensor) -> torch.Tensor: - return torch.empty_like("") # type: ignore[arg-type] +def get_container_json_metadata_abstract(decoder: torch.Tensor) -> str: + return "" @impl_abstract("torchcodec_ns::get_stream_json_metadata") -def get_stream_json_metadata_abstract( - decoder: torch.Tensor, stream_idx: int -) -> torch.Tensor: - return torch.empty_like("") # type: ignore[arg-type] +def get_stream_json_metadata_abstract(decoder: torch.Tensor, stream_idx: int) -> str: + return "" @impl_abstract("torchcodec_ns::_get_json_ffmpeg_library_versions") -def _get_json_ffmpeg_library_versions_abstract() -> torch.Tensor: - return torch.empty_like("") # type: ignore[arg-type] +def _get_json_ffmpeg_library_versions_abstract() -> str: + return "" @impl_abstract("torchcodec_ns::scan_all_streams_to_update_metadata")