From eaf91f09321a1086b0f869e965ac28c9e91800ba Mon Sep 17 00:00:00 2001 From: Hanno Schlichting Date: Mon, 24 Jul 2017 21:13:06 +0200 Subject: [PATCH 1/3] Use the right python executable. --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index a47902a0..2b873156 100644 --- a/Makefile +++ b/Makefile @@ -18,9 +18,9 @@ TRAVIS_PYTHON_VERSION ?= $(shell $(PYTHON_EXE) -c "import sys; print('.'.join([s GREENLET_SUPPORTED = yes ifeq ($(findstring 3.,$(TRAVIS_PYTHON_VERSION)), 3.) GREENLET_SUPPORTED = no - VENV_CMD = python -m venv . + VENV_CMD = $(PYTHON_EXE) -m venv . else - VENV_CMD = python -m virtualenv . + VENV_CMD = $(PYTHON_EXE) -m virtualenv . endif ifeq ($(PYPY),yes) GREENLET_SUPPORTED = no From 4ebeb1550b8e1adc9fe278efd07b2ff4694b011f Mon Sep 17 00:00:00 2001 From: Hanno Schlichting Date: Mon, 24 Jul 2017 21:07:41 +0200 Subject: [PATCH 2/3] Remove deprecated `pip --download-cache` option. --- .gitignore | 1 - .travis.yml | 2 +- Makefile | 4 ---- 3 files changed, 1 insertion(+), 6 deletions(-) diff --git a/.gitignore b/.gitignore index 19bc5703..84cb76a9 100644 --- a/.gitignore +++ b/.gitignore @@ -27,7 +27,6 @@ site-packages/ zookeeper/ .coverage .idea -.pip_cache .project .pydevproject .tox diff --git a/.travis.yml b/.travis.yml index 4feeb079..748dd769 100644 --- a/.travis.yml +++ b/.travis.yml @@ -4,8 +4,8 @@ addons: packages: - libevent-dev cache: + pip: true directories: - - "$HOME/.cache/pip" - zookeeper language: python python: diff --git a/Makefile b/Makefile index 2b873156..677c366f 100644 --- a/Makefile +++ b/Makefile @@ -1,11 +1,7 @@ HERE = $(shell pwd) BIN = $(HERE)/bin PYTHON = $(BIN)/python -PIP_DOWNLOAD_CACHE ?= $(HERE)/.pip_cache INSTALL = $(BIN)/pip install -ifneq ($(TRAVIS), true) - INSTALL += --download-cache $(PIP_DOWNLOAD_CACHE) -endif TOX_VENV ?= py27 BUILD_DIRS = bin build include lib lib64 man share From 698873a6cbcef61615a0e39d09134eff1f367a94 Mon Sep 17 00:00:00 2001 From: Hanno Schlichting Date: Mon, 24 Jul 2017 21:12:48 +0200 Subject: [PATCH 3/3] Remove unused GEVENT_VERSION env variable. --- Makefile | 2 -- kazoo/tests/test_build.py | 9 --------- 2 files changed, 11 deletions(-) diff --git a/Makefile b/Makefile index 677c366f..61fbc412 100644 --- a/Makefile +++ b/Makefile @@ -5,7 +5,6 @@ INSTALL = $(BIN)/pip install TOX_VENV ?= py27 BUILD_DIRS = bin build include lib lib64 man share -GEVENT_VERSION ?= 1.0.1 PYTHON_EXE = $(shell [ -f $(PYTHON) ] && echo $(PYTHON) || echo python) PYPY = $(shell $(PYTHON_EXE) -c "import sys; print(getattr(sys, 'pypy_version_info', False) and 'yes' or 'no')") TRAVIS ?= false @@ -33,7 +32,6 @@ build: $(PYTHON) ifeq ($(GREENLET_SUPPORTED),yes) $(INSTALL) -U -r requirements_eventlet.txt $(INSTALL) -U -r requirements_gevent.txt - $(INSTALL) -f https://github.com/surfly/gevent/releases gevent==$(GEVENT_VERSION) endif ifneq ($(TRAVIS), true) $(INSTALL) -U -r requirements_sphinx.txt diff --git a/kazoo/tests/test_build.py b/kazoo/tests/test_build.py index 0f778a67..b8e4bbcb 100644 --- a/kazoo/tests/test_build.py +++ b/kazoo/tests/test_build.py @@ -12,15 +12,6 @@ def setUp(self): if not os.environ.get('TRAVIS'): raise SkipTest('Only run build config tests on Travis.') - def test_gevent_version(self): - try: - import gevent - except ImportError: - raise SkipTest('gevent not available.') - env_version = os.environ.get('GEVENT_VERSION') - if env_version: - self.assertEqual(env_version, gevent.__version__) - def test_zookeeper_version(self): server_version = self.client.server_version() server_version = '.'.join([str(i) for i in server_version])