Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "setup.py test" from documentation and add a CHANGELOG entry for 3.6.1 #3543

Closed
nicoddemus opened this issue Jun 6, 2018 · 3 comments
Labels
good first issue easy issue that is friendly to new contributor type: docs documentation improvement, missing or needing clarification

Comments

@nicoddemus
Copy link
Member

Followup of #3536

@nicoddemus nicoddemus added type: docs documentation improvement, missing or needing clarification good first issue easy issue that is friendly to new contributor labels Jun 6, 2018
@pytestbot
Copy link
Contributor

GitMate.io thinks possibly related issues are #3538 (3.6.1 section missing from changelog), #3536 (3.6.1 fails on "setup.py test"), #582 (setup.py test documentation is broken), #1632 (Remove py.test* commands as entry points), and #592 (py.test hangs after update from 2.5 to 2.6.2).

@nicoddemus
Copy link
Member Author

Actually as pointed out by #3536 (comment), we don't actually need to remove that section of the docs...

@asottile
Copy link
Member

asottile commented Jun 7, 2018

I assume we should remove the code as well:

pytest/setup.py

Lines 118 to 135 in 1815765

class PyTest(Command):
user_options = []
def initialize_options(self):
pass
def finalize_options(self):
pass
def run(self):
import subprocess
python_path = [x for x in os.environ.get("PYTHONPATH", "").split(":") if x]
python_path.insert(0, os.getcwd())
os.environ["PYTHONPATH"] = ":".join(python_path)
errno = subprocess.call([sys.executable, "pytest.py", "--ignore=doc"])
raise SystemExit(errno)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue easy issue that is friendly to new contributor type: docs documentation improvement, missing or needing clarification
Projects
None yet
Development

No branches or pull requests

3 participants