Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

invesitgate and fix function wrapper unpacking #3440

Closed
RonnyPfannschmidt opened this issue May 3, 2018 · 3 comments
Closed

invesitgate and fix function wrapper unpacking #3440

RonnyPfannschmidt opened this issue May 3, 2018 · 3 comments
Labels
type: bug problem that needs to be addressed

Comments

@RonnyPfannschmidt
Copy link
Member

follow-up to #3435

it seems plausible that we missed some cases where signature usage may or may not depend on wrapper following, we should review the places where we handle wrappers and their unpacking
@pytestbot
Copy link
Contributor

GitMate.io thinks possibly related issues are #277 (Markers as functions), #13 (INTERNALERROR on Wrapper ), #231 (Duplicate function "pytest_pyfunc_call"), #2435 (f), and #3320 ([question] Multithreaded support in a function).

@pytestbot pytestbot added the type: bug problem that needs to be addressed label May 3, 2018
@nicoddemus
Copy link
Member

I believe this is no longer an issue as we now correctly deal with Python 2 unwrapping. Should we close this?

@Zac-HD
Copy link
Member

Zac-HD commented Jun 24, 2019

Yep, looks like it was only Py2 handling and that's now been fixed.

@Zac-HD Zac-HD closed this as completed Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug problem that needs to be addressed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@RonnyPfannschmidt @nicoddemus @Zac-HD @pytestbot