Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bug in simple index test suite #8617

Closed
alanbato opened this issue Sep 28, 2020 · 1 comment · Fixed by #8864
Closed

Possible bug in simple index test suite #8617

alanbato opened this issue Sep 28, 2020 · 1 comment · Fixed by #8864
Labels
testing Test infrastructure and individual tests

Comments

@alanbato
Copy link
Contributor

While working on some related tests for my proof of concept solution to #726, I came across this test
It appears that we're trying to test different combinations of file types and version formats, but not all version formats are being actually used.

https://github.com/pypa/warehouse/blob/fea98d9c054ebae63bd5d1fc478428d2efde6670/tests/unit/legacy/api/test_simple.py#L144-L158

If this is not intended, I'd be happy to submit a small fix :)

@di
Copy link
Member

di commented Sep 28, 2020

I think that test could probably use some improvement, it's a bit old at this point and could benefit from parametrization, at the very lease. 🙂

@di di added the testing Test infrastructure and individual tests label Sep 28, 2020
@di di closed this as completed in #8864 Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Test infrastructure and individual tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants