From ef5868f691ec2afc3320e6278d83d69a072ccbc9 Mon Sep 17 00:00:00 2001
From: chrysle <i.kant@posteo.de>
Date: Sun, 28 Apr 2024 15:07:43 +0200
Subject: [PATCH] Apply suggestions from code review
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <578543+webknjaz@users.noreply.github.com>
---
 .github/workflows/ci.yml | 14 ++++----------
 1 file changed, 4 insertions(+), 10 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index e36ee02..b15ae37 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -22,17 +22,10 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v4
-    - name: Determine Python versions
-      run: |
-        {
-          echo 'PYTHON_VERSIONS<<EOF'
-          cat  '.python-versions-used'
-          echo 'EOF'
-        } >> $GITHUB_ENV
     - name: Set up Python
       uses: actions/setup-python@v5
       with:
-        python-version: ${{env.PYTHON_VERSIONS}}
+        python-version-file: '.python-versions-used'
     - name: Install dependencies
       run: |
         python -m pip install -r requirements.txt
@@ -42,14 +35,15 @@ jobs:
         python -m nox --report report.json
     - name: Verify table has not been altered
       run: |
+        set -xeEuo pipefail
         cat report.json
         python report_to_table.py
         git diff table.md
         DIFF_FOR_TABLE=$(git diff table.md)
         echo "DIFF_FOR_TABLE=$DIFF_FOR_TABLE" >> $GITHUB_OUTPUT
       id: verify-table
-    - name: Fail the job
-      if: ${{ steps.verify-table.outputs.DIFF_FOR_TABLE != '' }}
+    - name: Fail the job if the committed table differs from the calculated one
+      if: steps.verify-table.outputs.DIFF_FOR_TABLE != ''
       run: |
         echo "::error file=table.md::Table has been altered but not committed!"
         exit 1