Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing scikit-learn plots to README.md #210

Closed
3 tasks
drbenvincent opened this issue Jun 14, 2023 · 3 comments
Closed
3 tasks

Add missing scikit-learn plots to README.md #210

drbenvincent opened this issue Jun 14, 2023 · 3 comments
Labels
documentation Improvements or additions to documentation

Comments

@drbenvincent
Copy link
Collaborator

drbenvincent commented Jun 14, 2023

  • modify docs/source/notebooks/generate_plots.ipynb to also generate and save the images from the scikit-learn version of the experiments
  • add missing example for ANCOVA into README.md
  • add missing example for Interrupted Time Series into README.md
@drbenvincent drbenvincent added the documentation Improvements or additions to documentation label Jun 14, 2023
@anevolbap
Copy link
Contributor

In docs/source/notebooks/ there is no scikit-learn version for ANCOVA or RK experiments, just ITS (SC and DiD which are already present in README.md).

Should those examples be created within the scope of this issue?

I started this PR tackling the first and third point.

@drbenvincent
Copy link
Collaborator Author

Thanks for this @anevolbap

So this issue is partly (but not fully) addressed by #307. I think we can create separate issues/PR's for new scikit-learn models (if they don't already exist).

I commented on the PR #307 I think that PR is actually ready to merge.

@anevolbap
Copy link
Contributor

@drbenvincent, I'll try to do the new scikit-learn models in a separate PR as you suggest. Afterwards, I hope to tackle more challenging issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants