From 875651b8021a27488685fba52250a594fa277f2a Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Sun, 22 Sep 2024 13:28:47 +0000 Subject: [PATCH] [Backport maintenance/3.3.x] Address pylint 3.3 messages (#2577) * Address pylint 3.3 messages (#2575) (cherry picked from commit 706fcdbe43230900c4425f5b8896b114be4c1024) --- astroid/bases.py | 8 +++----- astroid/exceptions.py | 2 +- astroid/nodes/_base_nodes.py | 2 +- astroid/nodes/node_classes.py | 4 ++-- astroid/typing.py | 2 +- pylintrc | 3 +++ 6 files changed, 11 insertions(+), 10 deletions(-) diff --git a/astroid/bases.py b/astroid/bases.py index 4a684cf1f..4a0d15265 100644 --- a/astroid/bases.py +++ b/astroid/bases.py @@ -147,7 +147,7 @@ def _infer_stmts( stmts: Iterable[InferenceResult], context: InferenceContext | None, frame: nodes.NodeNG | BaseInstance | None = None, -) -> collections.abc.Generator[InferenceResult, None, None]: +) -> collections.abc.Generator[InferenceResult]: """Return an iterator on statements inferred by each statement in *stmts*.""" inferred = False constraint_failed = False @@ -354,7 +354,7 @@ def infer_binary_op( other: InferenceResult, context: InferenceContext, method: SuccessfulInferenceResult, - ) -> Generator[InferenceResult, None, None]: + ) -> Generator[InferenceResult]: return method.infer_call_result(self, context) def __repr__(self) -> str: @@ -491,9 +491,7 @@ def _infer_builtin_new( self, caller: SuccessfulInferenceResult | None, context: InferenceContext, - ) -> collections.abc.Generator[ - nodes.Const | Instance | UninferableBase, None, None - ]: + ) -> collections.abc.Generator[nodes.Const | Instance | UninferableBase]: if not isinstance(caller, nodes.Call): return if not caller.args: diff --git a/astroid/exceptions.py b/astroid/exceptions.py index dd78a81ff..126acb954 100644 --- a/astroid/exceptions.py +++ b/astroid/exceptions.py @@ -230,7 +230,7 @@ class InferenceError(ResolveError): # pylint: disable=too-many-instance-attribu context: InferenceContext object. """ - def __init__( # pylint: disable=too-many-arguments + def __init__( # pylint: disable=too-many-arguments, too-many-positional-arguments self, message: str = "Inference failed for {node!r}.", node: InferenceResult | None = None, diff --git a/astroid/nodes/_base_nodes.py b/astroid/nodes/_base_nodes.py index 96c3c1c06..2d210f17a 100644 --- a/astroid/nodes/_base_nodes.py +++ b/astroid/nodes/_base_nodes.py @@ -42,7 +42,7 @@ InferenceContext, InferenceContext, ], - list[partial[Generator[InferenceResult, None, None]]], + list[partial[Generator[InferenceResult]]], ] diff --git a/astroid/nodes/node_classes.py b/astroid/nodes/node_classes.py index 1924c78eb..5ce00e3d6 100644 --- a/astroid/nodes/node_classes.py +++ b/astroid/nodes/node_classes.py @@ -82,7 +82,7 @@ def _is_const(value) -> bool: ] InferBinaryOperation = Callable[ [_NodesT, Optional[InferenceContext]], - Generator[Union[InferenceResult, _BadOpMessageT], None, None], + Generator[Union[InferenceResult, _BadOpMessageT]], ] InferLHS = Callable[ [_NodesT, Optional[InferenceContext]], @@ -737,7 +737,7 @@ def __init__( self.vararg_node = vararg_node self.kwarg_node = kwarg_node - # pylint: disable=too-many-arguments + # pylint: disable=too-many-arguments, too-many-positional-arguments def postinit( self, args: list[AssignName] | None, diff --git a/astroid/typing.py b/astroid/typing.py index 27d95c21f..77cc12030 100644 --- a/astroid/typing.py +++ b/astroid/typing.py @@ -76,7 +76,7 @@ class AstroidManagerBrain(TypedDict): "InferenceContext", SuccessfulInferenceResult, ], - Generator[InferenceResult, None, None], + Generator[InferenceResult], ] diff --git a/pylintrc b/pylintrc index 76aa73716..d605bc482 100644 --- a/pylintrc +++ b/pylintrc @@ -301,6 +301,9 @@ exclude-protected=_asdict,_fields,_replace,_source,_make # Maximum number of arguments for function / method max-args=10 +# Maximum number of positional arguments for function / method. +max-positional-arguments=8 + # Argument names that match this expression will be ignored. Default to name # with leading underscore