Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cached-property 2.0 wheel incorrectly fetched on python 2 systems #356

Closed
fervand1 opened this issue Oct 25, 2024 · 5 comments
Closed

cached-property 2.0 wheel incorrectly fetched on python 2 systems #356

fervand1 opened this issue Oct 25, 2024 · 5 comments

Comments

@fervand1
Copy link

The new release 2.0 is failing python 2 pipelines. The version is incorrectly fetched when it should not be compatible on python 2 systems at all. Following issue is logged in the CI pipelines

    from zeep.client import Client
../venv_tmp/lib/python2.7/site-packages/zeep/__init__.py:1: in <module>
    from zeep.client import CachingClient, Client  # noqa
../venv_tmp/lib/python2.7/site-packages/zeep/client.py:5: in <module>
    from zeep.transports import Transport
../venv_tmp/lib/python2.7/site-packages/zeep/transports.py:9: in <module>
    from zeep.wsdl.utils import etree_to_string
../venv_tmp/lib/python2.7/site-packages/zeep/wsdl/__init__.py:16: in <module>
    from zeep.wsdl.wsdl import Document  # noqa
../venv_tmp/lib/python2.7/site-packages/zeep/wsdl/wsdl.py:22: in <module>
    from zeep.xsd import Schema
../venv_tmp/lib/python2.7/site-packages/zeep/xsd/__init__.py:7: in <module>
    from zeep.xsd.elements import *  # noqa
../venv_tmp/lib/python2.7/site-packages/zeep/xsd/elements/__init__.py:4: in <module>
    from .indicators import *  # noqa
../venv_tmp/lib/python2.7/site-packages/zeep/xsd/elements/indicators.py:18: in <module>
    from cached_property import threaded_cached_property
../venv_tmp/lib/python2.7/site-packages/cached_property.py:9: in <module>
    import asyncio
E   ImportError: No module named asyncio

@pydanny can a new wheel be released with fixed python version marker? Thanks for your support

@fervand1 fervand1 changed the title cached-property 2.0 release incorrectly fetched on python 2 systems cached-property 2.0 wheel incorrectly fetched on python 2 systems Oct 25, 2024
@pydanny
Copy link
Owner

pydanny commented Oct 25, 2024

@fervand1 Thanks for letting me know. Is this what needs to be done? #357

@pydanny
Copy link
Owner

pydanny commented Oct 25, 2024

Also, once this is up, do I need to yank the 3.8 release?

@fervand1
Copy link
Author

@pydanny Yes you will need to yank the last release 2.0. We had similar issue with isodate few weeks back here https://pypi.org/project/isodate/#history
Thanks for the quick fix

@pydanny
Copy link
Owner

pydanny commented Oct 25, 2024

Deployed onto PyPI. Please confirm all is good.

@pydanny pydanny closed this as completed Oct 25, 2024
@fervand1
Copy link
Author

Its fixed 🎉 Can confirm all checks have passed. Thanks again @pydanny Happy Friday!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants