Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEV: Testing for make_release.py #2463

Closed
stefan6419846 opened this issue Feb 19, 2024 · 0 comments · Fixed by #2462
Closed

DEV: Testing for make_release.py #2463

stefan6419846 opened this issue Feb 19, 2024 · 0 comments · Fixed by #2462
Labels
is-maintenance Anything that is just internal: Simplifying code, syntax changes, updating docs, speed improvements

Comments

@stefan6419846
Copy link
Collaborator

Explanation

make_release.py is mostly untested and by modifying it, it is not always clear if everything still works correctly or whether something broke accidentally.

For this reason, we might consider some basic unit/integration tests for it to cover edge cases like #2462, #2246, ...
@stefan6419846 stefan6419846 added the is-maintenance Anything that is just internal: Simplifying code, syntax changes, updating docs, speed improvements label Feb 19, 2024
@stefan6419846 stefan6419846 linked a pull request Feb 26, 2024 that will close this issue
DEV: Fix changelog for UTF-8 characters #2462
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
is-maintenance Anything that is just internal: Simplifying code, syntax changes, updating docs, speed improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DEV: Fix changelog for UTF-8 characters stefan6419846/pypdf
1 participant
@stefan6419846