Don't Copy The Whole Validator Map each time #5780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5780 +/- ##
==========================================
- Coverage 57.97% 57.24% -0.74%
==========================================
Files 312 312
Lines 26506 26155 -351
==========================================
- Hits 15368 14973 -395
- Misses 9033 9084 +51
+ Partials 2105 2098 -7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Code Cleanup
What does this PR do? Why is it needed?
Refactor to only append validators and internally add pubkeys to our validator index map.
This makes each map track the validator field as its 'reference'. We only copy the whole map once per deposit, so as to reduce the time spent of map copies.Which issues(s) does this PR fix?
Part of #5779
Other notes for review