Fix cold state generation #5770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
added
Ready For Review
rauljordan
approved these changes
May 6, 2020
Codecov Report
@@ Coverage Diff @@
## master #5770 +/- ##
=======================================
Coverage 41.68% 41.68%
=======================================
Files 300 300
Lines 25726 25726
=======================================
Hits 10723 10723
Misses 13092 13092
Partials 1911 1911 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
This fixes cold state generation. As we found a few edge cases while testing get state end point. This PR fixed those edge cases and guarantee cold state at any slot can successfully be generated
Which issues(s) does this PR fix?
Fixes #5754