Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More explicit error message on wrong process when running prysm.sh #5747

Merged
merged 3 commits into from
May 5, 2020

Conversation

farazdagi
Copy link
Contributor

What type of PR is this?

Other

What does this PR do? Why is it needed?

  • Fixes a bug: when incorrect process name was used, process didn't exit properly
    image

  • Adds more explicit error message, where it mentions what process has been called - helps us debugging as well:
    image

Which issues(s) does this PR fix?

Fixes #5735

Other notes for review

@farazdagi farazdagi added the Ready For Review A pull request ready for code review label May 5, 2020
@farazdagi farazdagi requested a review from a team as a code owner May 5, 2020 12:01
@farazdagi farazdagi self-assigned this May 5, 2020
@codecov
Copy link

codecov bot commented May 5, 2020

Codecov Report

Merging #5747 into master will decrease coverage by 20.93%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #5747       +/-   ##
===========================================
- Coverage   43.20%   22.26%   -20.94%     
===========================================
  Files         270      180       -90     
  Lines       23569    15790     -7779     
===========================================
- Hits        10182     3516     -6666     
- Misses      11555    11723      +168     
+ Partials     1832      551     -1281     

Copy link
Member

@terencechain terencechain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@prylabs-bulldozer prylabs-bulldozer bot merged commit 45f2447 into master May 5, 2020
@delete-merged-branch delete-merged-branch bot deleted the prysm-sh-running-slasher branch May 5, 2020 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slasher: PROCESS can be beacon-chain or validator.
2 participants