Increase regen historical state cache size #5613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
commented
Apr 24, 2020
0xKiwi
reviewed
Apr 24, 2020
| // Using max possible size to avoid using DB to save and retrieve pre state (slow) | ||
| // The size is 80 because block at slot 43772 built on top of block at slot 43693. | ||
| // That is the worst case. | ||
| cacheState, err := lru.New(80) |
There was a problem hiding this comment.
Should this be a global constant? Just so its not hardcoded into a parameter.
Codecov Report
@@ Coverage Diff @@
## master #5613 +/- ##
===========================================
+ Coverage 13.04% 47.01% +33.97%
===========================================
Files 116 239 +123
Lines 9285 20738 +11453
===========================================
+ Hits 1211 9750 +8539
- Misses 7865 9235 +1370
- Partials 209 1753 +1544 |
0xKiwi
approved these changes
Apr 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #5611. It has no impact to beacon node run time, it only impacts the duration when beacon node is generating and saving historical states. It's 8 mins given current chain length
Change list:
regenHistoricalStates