Add hotfix for E2E #5573
Merged
Add hotfix for E2E #5573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -116,7 +116,7 @@ func validatorsParticipating(conns ...*grpc.ClientConn) error { | |||
| } | |||
|
|
|||
| partRate := participation.Participation.GlobalParticipationRate | |||
| expected := float32(1) | |||
| expected := float32(0.85) | |||
There was a problem hiding this comment.
Don't forget to add a TODO issue here : )
terencechain
approved these changes
Apr 21, 2020
Codecov Report
@@ Coverage Diff @@
## master #5573 +/- ##
===========================================
- Coverage 41.42% 19.77% -21.66%
===========================================
Files 239 236 -3
Lines 20635 20545 -90
===========================================
- Hits 8548 4062 -4486
- Misses 10476 15814 +5338
+ Partials 1611 669 -942 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lowers the minimum participation required in E2E so it can pass. Tracking issue made #5572 to make sure we tackle the real problem.