Set a max limit for decoding ssz objects from p2p #5295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonvanloon
added
Ready For Review
nisdas
approved these changes
Apr 2, 2020
Codecov Report
@@ Coverage Diff @@
## master #5295 +/- ##
===========================================
+ Coverage 23.85% 40.64% +16.78%
===========================================
Files 234 233 -1
Lines 19716 19361 -355
===========================================
+ Hits 4704 7869 +3165
+ Misses 14144 10100 -4044
- Partials 868 1392 +524 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec defines a 1Mb chunk size limit that was not enforced in Prysm's network decoder.
https://github.com/ethereum/eth2.0-specs/blob/dev/specs/phase0/p2p-interface.md#configuration
Discovered in fuzz testing when the test tried to send a 84 byte message with a length of over 9000 petabytes.