Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait For Chainstart to Start P2P Service #5291

Closed
nisdas opened this issue Apr 2, 2020 · 1 comment · Fixed by #5303
Closed

Wait For Chainstart to Start P2P Service #5291

nisdas opened this issue Apr 2, 2020 · 1 comment · Fixed by #5303
Assignees
Labels
Networking P2P related items

Comments

@nisdas
Copy link
Member

nisdas commented Apr 2, 2020

ethereum/consensus-specs#1700

Building on from the above issue we will need to start our p2p service at chainstart instead of when the node starts up to avoid the situation of having 2 different fork digests to reconcile in pre-genesis and post-genesis. This would mean that peer discovery would only begin when we have the relevant chainstart eth1 block confirmed.

@rauljordan
Copy link
Contributor

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Networking P2P related items
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants