Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

status=UNKNOWN_STATUS should show "ETH1 DEPOSIT RECEIVED" when appropriate #5059

Closed
superphiz opened this issue Mar 10, 2020 · 5 comments
Closed
Assignees
Labels
Enhancement New feature or request Help Wanted Extra attention is needed
Milestone

Comments

@superphiz
Copy link

UNKNOWN_STATUS is extremely vague and is certain to cause a lot of turmoil in the minds of new stakers when we go live. Showing that an Eth1 deposit has been received before the validator is pending inclusion will enhance the quality of the product in the minds of end users. There may be other appropriate status updates that could be included.

@prestonvanloon
Copy link
Member

Good point that UNKNOWN is a bit concerning. It simply means that the status was not set.

We should look into adding or fixing eth1 deposit received. We should be returning a status to indicate that the beacon node has seen the eth1 deposit.

We could also display "Awaiting deposit" or something along those lines if the deposit has not been observed in eth1 deposit contract.

@prestonvanloon prestonvanloon added Enhancement New feature or request Help Wanted Extra attention is needed labels Mar 24, 2020
@prestonvanloon prestonvanloon added this to the Diamond milestone Apr 10, 2020
@rauljordan
Copy link
Contributor

Assigning to @0xKiwi as this is part fo the validator activation process in the client

@0xKiwi
Copy link
Contributor

0xKiwi commented Apr 14, 2020

I intend to make some larger scale logging improvements for validator status after #5396 is merged. Have you tried a new validator deposit within the last few days @superphiz ?

1 similar comment
@0xKiwi
Copy link
Contributor

0xKiwi commented Apr 14, 2020

I intend to make some larger scale logging improvements for validator status after #5396 is merged. Have you tried a new validator deposit within the last few days @superphiz ?

@0xKiwi
Copy link
Contributor

0xKiwi commented Apr 14, 2020

I intend to make some larger scale logging improvements for validator status after #5396 is merged. Some improvements were already made in #5389. @superphiz would you mind letting me know if the experience has improved when we restart our testnet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Help Wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants