Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate GenesisBeaconState Function and Make OptimizedGenesisBeaconState Default #4446

Closed
rauljordan opened this issue Jan 7, 2020 · 2 comments
Closed

Deprecate GenesisBeaconState Function and Make OptimizedGenesisBeaconState Default #4446

rauljordan opened this issue Jan 7, 2020 · 2 comments
Labels
Enhancement New feature or request Priority: Low Low priority item

Comments

@rauljordan
Copy link
Contributor

Hi all, in the v0.9.2 branch we introduced an OptimizedGenesisBeaconState function which does not process deposits at the start. We maintained an old, spec-complaint version called GenesisBeaconState which we should be deprecated as it is only used in tests and has duplicated logic with the optimized version.
@rauljordan rauljordan added Enhancement New feature or request Priority: Low Low priority item labels Jan 7, 2020
@rauljordan rauljordan mentioned this issue Jan 7, 2020
Merged
@nisdas
Copy link
Member

nisdas commented Jan 7, 2020 •
edited
Loading

GenesisBeaconState calls OptimizedGenesisBeaconState too
https://github.com/prysmaticlabs/prysm/blob/v0.9.2/beacon-chain/core/state/state.go#L94 . I think we can leave it as it is, or change the name of OptimizedGenesisBeaconState . Maybe the naming is misleading

@rauljordan
Copy link
Contributor Author

Closing this - it's not a big deal and didn't realize one called the other

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement New feature or request Priority: Low Low priority item
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rauljordan @nisdas