Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Custom State HashTreeRoot Caching for Arrays of Roots #4445

Closed
rauljordan opened this issue Jan 7, 2020 · 1 comment
Closed

Fix Custom State HashTreeRoot Caching for Arrays of Roots #4445

rauljordan opened this issue Jan 7, 2020 · 1 comment
Labels
Bug Something isn't working Help Wanted Extra attention is needed Priority: Medium Medium priority item

Comments

@rauljordan
Copy link
Contributor

Hi all,

In #4154 we implemented a custom HashTreeRoot for our beacon state data structure. A major optimization included in there is caching for fields such as BlockRoots [8192][32]byte and other arrays of Merkle roots. Unfortunately, the cache is seeing some collisions at runtime leading to problems in state transitions. This needs to be gated behind a feature flag to toggle it here and explorer further.
@rauljordan rauljordan added Bug Something isn't working Help Wanted Extra attention is needed Priority: Medium Medium priority item labels Jan 7, 2020
@rauljordan rauljordan mentioned this issue Jan 7, 2020
Merged
@rauljordan rauljordan mentioned this issue Jan 15, 2020
Merged
@rauljordan
Copy link
Contributor Author

Done by #4558

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working Help Wanted Extra attention is needed Priority: Medium Medium priority item
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rauljordan