Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Genesis validators incorrect when min genesis time in future #4370

Closed
prestonvanloon opened this issue Dec 29, 2019 · 2 comments · Fixed by #4373
Closed

Genesis validators incorrect when min genesis time in future #4370

prestonvanloon opened this issue Dec 29, 2019 · 2 comments · Fixed by #4373
Assignees
@nisdas
Labels
Bug Something isn't working Priority: Critical Highest, immediate priority item
Milestone
Testnet restart f...

Comments

@prestonvanloon
Copy link
Member

prestonvanloon commented Dec 29, 2019 •
edited
Loading

Problem scenario:

  • Send more than MinGenesisActiveValidatorCount valid deposits before MinGenesisTime.
  • When current time exceeds MinGenesisTime, all valid deposits are added to the genesis state.
  • New nodes that sync after genesis time have only MinGenesisActiveValidatorCount validators.

Expected behavior:

  • Same behavior as pre-genesis nodes.

Edit: Edited to update based on feedback from @nisdas.
@prestonvanloon prestonvanloon added Bug Something isn't working Priority: Critical Highest, immediate priority item labels Dec 29, 2019
This was referenced Dec 29, 2019
Merged
Merged
@prestonvanloon prestonvanloon mentioned this issue Dec 30, 2019
Merged
@prestonvanloon
Copy link
Member Author

Re-opening. I believe there is still an issue here. From my observation, if the number of genesis validators is not exactly the min amount then there are problems for new nodes to sync to the network after the chain has started.

@nisdas nisdas mentioned this issue Dec 31, 2019
Merged
4 tasks
@prestonvanloon
Copy link
Member Author

This should be resolved in v0.9.2 from #4329

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nisdas nisdas

Labels
Bug Something isn't working Priority: Critical Highest, immediate priority item
Projects
None yet
Milestone
Testnet restart for v0.9.1, v0.9.2, v...
Development

Successfully merging a pull request may close this issue.

Only add chain start deposits up to min genesis active validator count prysmaticlabs/prysm
2 participants
@prestonvanloon @nisdas