Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It's better add comments on param BlockBatchLimit #13499

Closed
tmors opened this issue Jan 23, 2024 · 0 comments · Fixed by #13502
Closed

It's better add comments on param BlockBatchLimit #13499

tmors opened this issue Jan 23, 2024 · 0 comments · Fixed by #13502
Assignees

Comments

@tmors
Copy link
Contributor

tmors commented Jan 23, 2024

💎 Issue

Background

When i upgraded my Goerli beacon-chain, i found that i couldn't sync blocks . I enabled debug then i got an error msg that "Request exceeded max size 128".
After that I read the source code and found that the MaxRequestBlock is modified (from 1024 to 128), So BlockBatchLimit is changed (1024 is not supported)

func MaxRequestBlock(e primitives.Epoch) uint64 {
	if e >= BeaconConfig().DenebForkEpoch {
		return BeaconConfig().MaxRequestBlocksDeneb // 128 
	}
	return BeaconConfig().MaxRequestBlocks // 1024
}

, but I still use the parameters(--BlockBatchLimit 1024) as before. So i think a comment is necessary to remind that the maximum of the param

Context and background information on the discussion...

Description

	// BlockBatchLimit specifies the requested block batch size.
	BlockBatchLimit = &cli.IntFlag{
		Name:  "block-batch-limit",
		Usage: "The amount of blocks the local peer is bounded to request and respond to in a batch. **Maximum 128**",
		Value: 64,
	}

Just like above bold comments (Maximum 128) to remind the range of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants