Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing changes to persisted data #5

Closed
3 of 8 tasks
jonasmalacofilho opened this issue Dec 19, 2017 · 1 comment
Closed
3 of 8 tasks

Typing changes to persisted data #5

jonasmalacofilho opened this issue Dec 19, 2017 · 1 comment

Comments

@jonasmalacofilho
Copy link
Member

jonasmalacofilho commented Dec 19, 2017

The idea is to group all desired typing changes here, for a future migration.

  • add db.Metadata { name, value } (i.e. for storage of schemaVersion) (added in v1.1.0)
  • add db.CardRequest.clientIp
  • change CardRequested to CardRequested(client, card)
  • combine db.CardRequest.<id> and dbRemoteCallLog.id to provide Meta.RecId to AcessoCard's APIs
  • add db.CardRequest .startedAt/.requestedAt .created/.lastUpdated : Timestamp (added in v1.1.0)
  • add db.RemoteCallLog .startedAt .created : Timestamp (added in v1.1.0)
  • add CardRequestError.UnknownError
  • add CardRequestError.LimitReached (cards/user limit, not global limit)

Note: no such migration is planned at the moment, so none of this might get implemented.

@jonasmalacofilho
Copy link
Member Author

Closing; we're preparing for long-term (unassisted) operation (so no breaking changes desired) and a lot of requests have already been made without these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant