From c9a61e574f5a2b06f6b15b14c0c0ff56f8381d1f Mon Sep 17 00:00:00 2001 From: dcodeIO Date: Thu, 5 Jan 2017 21:56:06 +0100 Subject: [PATCH] Use full library for JSON modules and runtime dependency for static modules, fixes #621 --- cli/targets/static-module.js | 2 +- cli/util.js | 1 + cli/wrappers/commonjs.js | 2 +- cli/wrappers/default.js | 2 +- package.json | 2 +- 5 files changed, 5 insertions(+), 4 deletions(-) diff --git a/cli/targets/static-module.js b/cli/targets/static-module.js index 28dd392e7..580ca6fda 100644 --- a/cli/targets/static-module.js +++ b/cli/targets/static-module.js @@ -19,7 +19,7 @@ function static_module_target(root, options, callback) { if (err) return callback(err); try { - output = util.wrap(output, options); + output = util.wrap(output, protobuf.util.merge({ dependency: "protobufjs/runtime" }, options)); } catch (e) { callback(e); return; diff --git a/cli/util.js b/cli/util.js index aa8d0b271..7e8a92bbf 100644 --- a/cli/util.js +++ b/cli/util.js @@ -110,6 +110,7 @@ exports.wrap = function(OUTPUT, options) { wrap = fs.readFileSync(path.resolve(process.cwd(), name)).toString("utf8"); } wrap = wrap.replace(/%ROOT%/g, JSON.stringify(options.root || "default")); + wrap = wrap.replace(/%DEPENDENCY%/g, JSON.stringify(options.dependency || "protobufjs")); wrap = wrap.replace(/( *)%OUTPUT%/, function($0, $1) { return $1.length ? OUTPUT.replace(/^/mg, $1) : OUTPUT; }); diff --git a/cli/wrappers/commonjs.js b/cli/wrappers/commonjs.js index e4c942b25..cd5ca5a35 100644 --- a/cli/wrappers/commonjs.js +++ b/cli/wrappers/commonjs.js @@ -1,6 +1,6 @@ "use strict"; -var $protobuf = require("protobufjs/runtime"); +var $protobuf = require(%DEPENDENCY%); %OUTPUT% diff --git a/cli/wrappers/default.js b/cli/wrappers/default.js index 288c6e801..b4699646d 100644 --- a/cli/wrappers/default.js +++ b/cli/wrappers/default.js @@ -4,7 +4,7 @@ define(["protobuf"], factory); /* CommonJS */ else if (typeof require === 'function' && typeof module === 'object' && module && module.exports) - module.exports = factory(require("protobufjs/runtime")); + module.exports = factory(require(%DEPENDENCY%)); })(this, function($protobuf) { "use strict"; diff --git a/package.json b/package.json index 26925374f..fd9fe0057 100644 --- a/package.json +++ b/package.json @@ -86,7 +86,7 @@ "vinyl-buffer": "^1.0.0", "vinyl-fs": "^2.4.4", "vinyl-source-stream": "^1.1.0", - "zuul": "^3.11.1", + "zuul": "dcodeIO/zuul", "zuul-ngrok": "^4.0.0" }, "cliDependencies": [