diff --git a/.travis.yml b/.travis.yml index 640f8c0c8..a9ca15883 100644 --- a/.travis.yml +++ b/.travis.yml @@ -4,26 +4,17 @@ node_js: - 4 - 6 - 7 -env: - - CXX=g++-4.8 +env: CXX=g++-4.8 addons: apt: - sources: - - ubuntu-toolchain-r-test - packages: - - g++-4.8 -script: - - npm test - - npm run bench + sources: ubuntu-toolchain-r-test + packages: g++-4.8 +script: npm test && npm run bench branches: - only: - - master + only: master matrix: include: - node_js: 6 - script: - - 'if [ "$SAUCE_USERNAME" ]; then travis_wait npm run zuul; sleep 3; fi' - include: + script: if [ -n "$SAUCE_USERNAME" ]; then travis_wait npm run zuul; sleep 3; fi - node_js: 6 - script: - - npm run coverage-ci + script: npm run coverage-ci diff --git a/README.md b/README.md index 2dba049b6..283603cd3 100644 --- a/README.md +++ b/README.md @@ -357,7 +357,7 @@ $> pbjs -t static-module file1.proto file2.proto | pbts -o bundle.d.ts - While using .proto files requires the [full library][dist-full] (about 18.5kb gzipped) or JSON at least the [light library][dist-light] (about 15.5kb gzipped), pretty much all code but the relatively short descriptors is shared and all features including reflection and the parser are available. -Static code, on the other hand, requires just the [minimal library][dist-minimal] (about 5.5kb gzipped), but generates additional, albeit editable, source code without any reflection features. +Static code, on the other hand, requires just the [minimal library][dist-minimal] (about 6kb gzipped), but generates additional, albeit editable, source code without any reflection features. There is no significant difference performance-wise as the code generated statically is pretty much the same as generated at runtime and both are largely interchangeable as seen in the previous section. diff --git a/src/rpc/service.js b/src/rpc/service.js index e26e41274..880bd04f0 100644 --- a/src/rpc/service.js +++ b/src/rpc/service.js @@ -18,7 +18,7 @@ var util = require("../util/minimal"); */ /** - * A service method part of an {@link rpc.ServiceMethodMixin|ServiceMethodMixin} and thus {@link rpc.Service} as created by {@link Service.create}. + * A service method part of a {@link rpc.ServiceMethodMixin|ServiceMethodMixin} and thus {@link rpc.Service} as created by {@link Service.create}. * @typedef rpc.ServiceMethod * @type {function} * @param {Message|Object} request Request message or plain object