forked from zcash/halo2
-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LagrangeBasis
trait
#279
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently
Basis
can refer to coefficients, lagrange basis or extended lagrange basis.Some functions like
halo2/halo2_backend/src/plonk/evaluation.rs
Line 836 in 0b75a92
does not make sense for coeffients. Needs to work only with lagrange.
the proposal is to add a new trait
LagrangeBasis
to use them for Lagrange basis polynomials.
The text was updated successfully, but these errors were encountered: