Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LagrangeBasis trait #279

Closed
adria0 opened this issue Feb 19, 2024 · 4 comments
Closed

Add LagrangeBasis trait #279

adria0 opened this issue Feb 19, 2024 · 4 comments

Comments

@adria0
Copy link
Member

adria0 commented Feb 19, 2024

Currently Basis can refer to coefficients, lagrange basis or extended lagrange basis.
Some functions like

pub fn evaluate<F: Field, B: Basis>(

does not make sense for coeffients. Needs to work only with lagrange.

the proposal is to add a new trait LagrangeBasis

pub trait LagrangeBasis: Copy + Debug + Send + Sync {}
impl LagrangeBasis for LagrangeCoeff {}
impl LagrangeBasis for ExtendedLagrangeCoeff {}

to use them for Lagrange basis polynomials.

@CPerezz
Copy link
Member

CPerezz commented Feb 20, 2024

I wouldn't dive too much on re-structuring the polynomial-related things here as we want to eventually migrate all the polynomial functionallity into a different repo/crate.

Just for info.

@adria0
Copy link
Member Author

adria0 commented Feb 21, 2024

Just a minor adjustment to improve correctness, that's all.

@ed255
Copy link
Member

ed255 commented Feb 29, 2024

This is addressed via #289 right?

@adria0
Copy link
Member Author

adria0 commented Mar 12, 2024

Done in #289

@adria0 adria0 closed this as completed Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants