From 51e132e5a81b4f613e60aff96121a76c651930f8 Mon Sep 17 00:00:00 2001 From: adria0 Date: Tue, 18 Jun 2024 12:14:12 +0200 Subject: [PATCH] Make clippy happy --- halo2_frontend/src/dev.rs | 11 ++++------- halo2_proofs/examples/circuit-layout.rs | 2 +- halo2_proofs/examples/proof-size.rs | 2 +- 3 files changed, 6 insertions(+), 9 deletions(-) diff --git a/halo2_frontend/src/dev.rs b/halo2_frontend/src/dev.rs index 5439c7a992..4b4ddbdf35 100644 --- a/halo2_frontend/src/dev.rs +++ b/halo2_frontend/src/dev.rs @@ -1529,10 +1529,7 @@ mod tests { let s_ltable = cells.query_selector(s_ltable); // If q is enabled, a must be in the table. - vec![ - (q.clone() * a.clone(), s_ltable.clone() * table), - (q * a, s_ltable * advice_table), - ] + vec![(q * a, s_ltable * table), (q * a, s_ltable * advice_table)] }); FaultyCircuitConfig { @@ -1607,7 +1604,7 @@ mod tests { let table = cells.query_instance(table, Rotation::cur()); // If q is enabled, a must be in the table. - vec![(q.clone() * a.clone(), table), (q * a, advice_table)] + vec![(q * a, table), (q * a, advice_table)] }); FaultyCircuitConfig { @@ -1750,8 +1747,8 @@ mod tests { // If q is enabled, a must be in the table. // If `s_ltable` is enabled, the value of `advice_table` & `table` is used as lookup table. vec![ - (q.clone() * a.clone(), table * s_ltable.clone()), - (q.clone() * a, advice_table * s_ltable.clone()), + (q * a, table * s_ltable), + (q * a, advice_table * s_ltable), (q, s_ltable), ] }); diff --git a/halo2_proofs/examples/circuit-layout.rs b/halo2_proofs/examples/circuit-layout.rs index 8516762adb..4a942387f8 100644 --- a/halo2_proofs/examples/circuit-layout.rs +++ b/halo2_proofs/examples/circuit-layout.rs @@ -243,7 +243,7 @@ impl Circuit for MyCircuit { let sc = meta.query_fixed(sc, Rotation::cur()); let sm = meta.query_fixed(sm, Rotation::cur()); - vec![a.clone() * sa + b.clone() * sb + a * b * sm - (c * sc) + sf * (d * e)] + vec![a * sa + b * sb + a * b * sm - (c * sc) + sf * (d * e)] }); PlonkConfig { diff --git a/halo2_proofs/examples/proof-size.rs b/halo2_proofs/examples/proof-size.rs index f1504e6f96..55133a8fb3 100644 --- a/halo2_proofs/examples/proof-size.rs +++ b/halo2_proofs/examples/proof-size.rs @@ -39,7 +39,7 @@ impl Circuit for TestCircuit { meta.lookup("lookup", |meta| { let selector = meta.query_selector(config.selector); - let not_selector = Expression::Constant(Fp::ONE) - selector.clone(); + let not_selector = Expression::Constant(Fp::ONE) - selector; let advice = meta.query_advice(config.advice, Rotation::cur()); vec![(selector * advice + not_selector, config.table)] });