From f95d3182295d59c2247b6684754bceb1ee8b5b8f Mon Sep 17 00:00:00 2001 From: Matthew Costabile Date: Thu, 15 Jul 2021 18:36:46 -0400 Subject: [PATCH 1/5] fix: mark sideEffects free --- package.json | 1 + 1 file changed, 1 insertion(+) diff --git a/package.json b/package.json index 6aa720e72bf..ef000b8bfaf 100644 --- a/package.json +++ b/package.json @@ -5,6 +5,7 @@ "main": "lib/index.js", "module": "lib-esm/index.js", "typings": "lib/index.d.ts", + "sideEffects": [], "scripts": { "start": "cd docs && npm run develop", "predist": "rm -rf dist & rm -rf lib & rm -rf lib-esm", From 05cef342bd8251f0a3e9732f2482fb29e33b6dcf Mon Sep 17 00:00:00 2001 From: Matthew Costabile Date: Sat, 17 Jul 2021 09:45:53 -0400 Subject: [PATCH 2/5] fix: update sideEffects delcaration in package.json to improve treeshaking --- package.json | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/package.json b/package.json index ef000b8bfaf..79569e5f092 100644 --- a/package.json +++ b/package.json @@ -5,7 +5,14 @@ "main": "lib/index.js", "module": "lib-esm/index.js", "typings": "lib/index.d.ts", - "sideEffects": [], + "sideEffects": [ + "lib/BaseStyles.js", + "lib-esm/BaseStyles.js", + "lib/behaviors/focusZone.js", + "lib-esm/behaviors/focusZone.js", + "lib/behaviors/focusTrap.js", + "lib-esm/behaviors/focusTrap.js" + ], "scripts": { "start": "cd docs && npm run develop", "predist": "rm -rf dist & rm -rf lib & rm -rf lib-esm", From 929b8bf46131d0cab57bd34dd50103e6a4d31cba Mon Sep 17 00:00:00 2001 From: Matthew Costabile Date: Sat, 17 Jul 2021 10:09:42 -0400 Subject: [PATCH 3/5] fix: update sideEffects delcaration in package.json to improve treeshaking --- package-lock.json | 2 +- package.json | 9 +++------ 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/package-lock.json b/package-lock.json index 2a904e3cfc8..964270abcaf 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,6 +1,6 @@ { "name": "@primer/components", - "version": "28.2.3", + "version": "28.2.5", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/package.json b/package.json index 79569e5f092..04a52372e78 100644 --- a/package.json +++ b/package.json @@ -6,12 +6,9 @@ "module": "lib-esm/index.js", "typings": "lib/index.d.ts", "sideEffects": [ - "lib/BaseStyles.js", - "lib-esm/BaseStyles.js", - "lib/behaviors/focusZone.js", - "lib-esm/behaviors/focusZone.js", - "lib/behaviors/focusTrap.js", - "lib-esm/behaviors/focusTrap.js" + "(lib|lib-esm)/BaseStyles.js", + "(lib|lib-esm)/behaviors/focusZone.js", + "(lib|lib-esm)/behaviors/focusTrap.js" ], "scripts": { "start": "cd docs && npm run develop", From 9bd047a6638ad51e3f09ba61a5a6af739de1192d Mon Sep 17 00:00:00 2001 From: Matthew Costabile Date: Sat, 17 Jul 2021 10:29:59 -0400 Subject: [PATCH 4/5] fix: BaseStyles doesnt use sideeffects --- package.json | 1 - 1 file changed, 1 deletion(-) diff --git a/package.json b/package.json index 04a52372e78..6d740777243 100644 --- a/package.json +++ b/package.json @@ -6,7 +6,6 @@ "module": "lib-esm/index.js", "typings": "lib/index.d.ts", "sideEffects": [ - "(lib|lib-esm)/BaseStyles.js", "(lib|lib-esm)/behaviors/focusZone.js", "(lib|lib-esm)/behaviors/focusTrap.js" ], From e756f91b8915ca7892d2a42e08fdb4b700bf99d0 Mon Sep 17 00:00:00 2001 From: Matthew Costabile Date: Sat, 17 Jul 2021 10:42:16 -0400 Subject: [PATCH 5/5] chore: add changeset --- .changeset/beige-years-notice.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/beige-years-notice.md diff --git a/.changeset/beige-years-notice.md b/.changeset/beige-years-notice.md new file mode 100644 index 00000000000..a26a6c97230 --- /dev/null +++ b/.changeset/beige-years-notice.md @@ -0,0 +1,5 @@ +--- +'@primer/components': patch +--- + +Side effects are properly declared in package.json