From 16f4ab4e69015567cf53bf5c3a1c3c38935eb94a Mon Sep 17 00:00:00 2001 From: Trevor Gau Date: Tue, 30 Mar 2021 17:02:42 -0400 Subject: [PATCH 1/2] Minor storybook fixes for Overlay --- src/stories/Overlay.stories.tsx | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/stories/Overlay.stories.tsx b/src/stories/Overlay.stories.tsx index dbc824cca13..9b7e7725062 100644 --- a/src/stories/Overlay.stories.tsx +++ b/src/stories/Overlay.stories.tsx @@ -1,15 +1,19 @@ /* eslint-disable @typescript-eslint/explicit-module-boundary-types */ import React, {useState, useRef} from 'react' import {Meta} from '@storybook/react' -import styled, {ThemeProvider} from 'styled-components' +import styled from 'styled-components' -import {BaseStyles, Overlay, Button, Text, ButtonDanger, theme, Position, Flex} from '..' +import {BaseStyles, Overlay, Button, Text, ButtonDanger, theme, ThemeProvider, Position, Flex} from '..' +import {registerPortalRoot} from '../Portal' export default { title: 'Internal components/Overlay', component: Overlay, decorators: [ Story => { + // Since portal roots are registered globally, we need this line so that each storybook + // story works in isolation. + registerPortalRoot(undefined) return ( From 1ae664df5382f3a5d207f682948dfd52567732c4 Mon Sep 17 00:00:00 2001 From: Trevor Gau Date: Mon, 5 Apr 2021 13:53:46 -0400 Subject: [PATCH 2/2] Formatting fix --- src/stories/Overlay.stories.tsx | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/stories/Overlay.stories.tsx b/src/stories/Overlay.stories.tsx index 795548a78ed..a686f66caf6 100644 --- a/src/stories/Overlay.stories.tsx +++ b/src/stories/Overlay.stories.tsx @@ -4,10 +4,8 @@ import {Meta} from '@storybook/react' import styled from 'styled-components' import {registerPortalRoot} from '../Portal' - import {BaseStyles, Overlay, Button, Text, ButtonDanger, ThemeProvider, Position, Flex} from '..' - export default { title: 'Internal components/Overlay', component: Overlay,