From 67d1e547be699cd8fc7820e7e2ea363e4eb918bd Mon Sep 17 00:00:00 2001 From: Tyler Jones Date: Fri, 20 Sep 2024 18:37:34 -0400 Subject: [PATCH] Update docs --- packages/react/src/Overlay/Overlay.docs.json | 6 ++++++ packages/react/src/Overlay/Overlay.tsx | 6 +++--- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/packages/react/src/Overlay/Overlay.docs.json b/packages/react/src/Overlay/Overlay.docs.json index 6377595594b..71de564937c 100644 --- a/packages/react/src/Overlay/Overlay.docs.json +++ b/packages/react/src/Overlay/Overlay.docs.json @@ -112,6 +112,12 @@ "defaultValue": "", "description": "If defined, Overlays will be rendered in the named portal. See also `Portal`." }, + { + "name": "focusTrap", + "type": "string", + "defaultValue": "true", + "description": "Determines if the `Overlay` recieves a focus trap or not" + }, { "name": "sx", "type": "SystemStyleObject" diff --git a/packages/react/src/Overlay/Overlay.tsx b/packages/react/src/Overlay/Overlay.tsx index d6f05a711fb..396dafa26c3 100644 --- a/packages/react/src/Overlay/Overlay.tsx +++ b/packages/react/src/Overlay/Overlay.tsx @@ -204,11 +204,11 @@ const Overlay = React.forwardRef( // To be backwards compatible with the old Overlay, we need to set the left prop if x-position is not specified const leftPosition: React.CSSProperties = left === undefined && right === undefined ? {left: 0} : {left} - const dialog = role && role !== 'dialog' ? true : false + const nonDialog = role && role !== 'dialog' ? true : false useFocusTrap({ containerRef: overlayRef, - disabled: !focusTrap || dialog, + disabled: !focusTrap || nonDialog, }) return ( @@ -217,7 +217,7 @@ const Overlay = React.forwardRef( height={height} width={width} role={role || 'dialog'} - aria-modal={dialog ? undefined : 'true'} + aria-modal={nonDialog ? undefined : 'true'} {...rest} ref={overlayRef} style={