Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refer to pug documentation for prettier formatting #32

Closed
Applelo opened this issue Nov 7, 2019 · 5 comments
Closed

Refer to pug documentation for prettier formatting #32

Applelo opened this issue Nov 7, 2019 · 5 comments
Labels
type: discussion type: documentation Improvements or additions to documentation working as intended The issue is working as intended

Comments

@Applelo
Copy link

Applelo commented Nov 7, 2019

It would be nice if you refer more to pug formatting like they do in there documentation.
For example use space instead of comma to separate attributes.

If it's possible, add an parameter to make Class and ID Literal optional.

@Shinigami92
Copy link
Member

Shinigami92 commented Nov 8, 2019

That was a design decision

#13

Edit

Oh I never documented this option in Readme 😱
https://github.com/prettier/plugin-pug/blob/master/src/options.ts

@Shinigami92 Shinigami92 added working as intended The issue is working as intended type: documentation Improvements or additions to documentation labels Nov 8, 2019
@Shinigami92
Copy link
Member

I updated the README.md

https://github.com/prettier/plugin-pug/blob/master/README.md#prettier-pug-specific-options

If you miss anything, please let me know
Otherwise feel free to close this issue

@Applelo
Copy link
Author

Applelo commented Nov 8, 2019

Like I said, is it possible to make optional the formatting of Class / ID to literal ?

@Shinigami92
Copy link
Member

Like I said, is it possible to make optional the formatting of Class / ID to literal ?

Have to think about it
I think I wont do it in the next few day, because I target bugs first and have prio to other projects

@Shinigami92 Shinigami92 changed the title Refer to pug documentation for prettier formatting Option for disabling formatting of Class and ID literals Nov 9, 2019
@Shinigami92 Shinigami92 changed the title Option for disabling formatting of Class and ID literals Refer to pug documentation for prettier formatting Nov 9, 2019
@Shinigami92
Copy link
Member

I extracted the feature request into it's own issue so it is more clean and better managable for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: discussion type: documentation Improvements or additions to documentation working as intended The issue is working as intended
Projects
None yet
Development

No branches or pull requests

2 participants