From 04fd02b68b7585861726ec462494b5fc0e866291 Mon Sep 17 00:00:00 2001 From: Justin Collins Date: Sun, 25 Apr 2021 20:20:50 -0700 Subject: [PATCH] Detect ::Rails.application.configure too Fixes #1584 --- lib/brakeman/processors/lib/rails4_config_processor.rb | 3 ++- test/apps/rails6/config/environments/production.rb | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/brakeman/processors/lib/rails4_config_processor.rb b/lib/brakeman/processors/lib/rails4_config_processor.rb index 3a11888c20..80322bb083 100644 --- a/lib/brakeman/processors/lib/rails4_config_processor.rb +++ b/lib/brakeman/processors/lib/rails4_config_processor.rb @@ -2,10 +2,11 @@ class Brakeman::Rails4ConfigProcessor < Brakeman::Rails3ConfigProcessor APPLICATION_CONFIG = s(:call, s(:call, s(:const, :Rails), :application), :configure) + ALT_APPLICATION_CONFIG = s(:call, s(:call, s(:colon3, :Rails), :application), :configure) # Look for Rails.application.configure do ... end def process_iter exp - if exp.block_call == APPLICATION_CONFIG + if exp.block_call == APPLICATION_CONFIG or exp.block_call == ALT_APPLICATION_CONFIG @inside_config = true process exp.block if sexp? exp.block @inside_config = false diff --git a/test/apps/rails6/config/environments/production.rb b/test/apps/rails6/config/environments/production.rb index 1a58ca5a0d..be82981c52 100644 --- a/test/apps/rails6/config/environments/production.rb +++ b/test/apps/rails6/config/environments/production.rb @@ -1,4 +1,4 @@ -Rails.application.configure do +::Rails.application.configure do # Settings specified here will take precedence over those in config/application.rb. # Code is not reloaded between requests.