From 0ba764e00d055abf6de2e44fbffdf8806cefd2e4 Mon Sep 17 00:00:00 2001
From: Vitor Avila <vitor.avila@preset.io>
Date: Wed, 10 Apr 2024 02:18:11 -0300
Subject: [PATCH] fix(dbt): Removing BQ-specific metadata from columns

---
 src/preset_cli/cli/superset/sync/dbt/datasets.py | 3 +++
 tests/cli/superset/sync/dbt/datasets_test.py     | 3 +++
 2 files changed, 6 insertions(+)

diff --git a/src/preset_cli/cli/superset/sync/dbt/datasets.py b/src/preset_cli/cli/superset/sync/dbt/datasets.py
index 000ec466..29547b91 100644
--- a/src/preset_cli/cli/superset/sync/dbt/datasets.py
+++ b/src/preset_cli/cli/superset/sync/dbt/datasets.py
@@ -46,6 +46,9 @@ def clean_metadata(metadata: Dict[str, Any]) -> Dict[str, Any]:
         "name",
         "nullable",
         "type_generic",
+        "precision",
+        "scale",
+        "max_length",
     ):
         if key in metadata:
             del metadata[key]
diff --git a/tests/cli/superset/sync/dbt/datasets_test.py b/tests/cli/superset/sync/dbt/datasets_test.py
index cc8825e6..e1f4f5fb 100644
--- a/tests/cli/superset/sync/dbt/datasets_test.py
+++ b/tests/cli/superset/sync/dbt/datasets_test.py
@@ -1391,6 +1391,9 @@ def test_clean_metadata() -> None:
         "nullable": "Nullable",
         "type_generic": "Type Generic",
         "yeah": "sure",
+        "precision": "very precise",
+        "scale": "to the max",
+        "max_length": 9000,
     }
     result = clean_metadata(test_data)
     assert result == {