Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: DBT Metrics Label vs Name #103

Closed
cwegener opened this issue Oct 7, 2022 · 1 comment · Fixed by #111
Closed

Discussion: DBT Metrics Label vs Name #103

cwegener opened this issue Oct 7, 2022 · 1 comment · Fixed by #111

Comments

@cwegener
Copy link

cwegener commented Oct 7, 2022

Hi Beto,

First off, big kudos to you for the last three weeks work on this project. I hadn't been paying attention to the project in the last three weeks and was just catching up with all the updates. This is really quickly turning into an indispensable tool for me!

Question:

I was wondering about the choice of using the the DBT metric 'name' field as the value for the Metric Label in Superset instead of using the DBT metric's 'label' field value.

Is there a specific reason for that? At first glance through the preset-cli codebase I couldn't spot if this is something that's even happening in the preset-cli codebase, or if this might just be a bug in the Superset API?

@betodealmeida
Copy link
Member

Thanks, @cwegener!

That was just an oversight, we should definitely use the label. Let me fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants