Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 allow non pd.DatetimeIndex for processing #127

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🎉 allow non pd.DatetimeIndex for processing #127

wants to merge 1 commit into from

Conversation

jvdd
Copy link
Member

@jvdd jvdd commented May 15, 2024 •
edited
Loading

Closes #125

TODO

  • update processing tests (currently only checks for datetimeindex)

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented May 15, 2024

CodSpeed Performance Report

Merging #127 will improve performances by 27.86%

Comparing non_time_idx_processing (f8d87ea) with main (e12e550)

Summary

⚡ 2 improvements
✅ 379 untouched benchmarks

Benchmarks breakdown

Benchmark main non_time_idx_processing Change
⚡ test_single_series_feature_collection_multiple_descriptors[2] 1.4 s 1.1 s +27.86%
⚡ test_single_series_feature_collection_multiple_descriptors[4] 456.3 ms 402.8 ms +13.26%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not assume datetimeindex in the processing functionality
1 participant
@jvdd