From 9579062809fcb658fa92d78a4152a6bebdd42c20 Mon Sep 17 00:00:00 2001 From: Jason Miller Date: Sun, 3 Mar 2019 00:16:44 -0500 Subject: [PATCH 1/2] Preserve the old `options.debounceRendering` instead of renaming it to `Component.debounce` --- src/component.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/component.js b/src/component.js index 2b64ae2b51..160f0244aa 100644 --- a/src/component.js +++ b/src/component.js @@ -1,5 +1,6 @@ import { assign } from './util'; import { diff, commitRoot } from './diff/index'; +import options from './options'; /** * Base Component class. Provides `setState()` and `forceUpdate()`, which @@ -123,7 +124,7 @@ const defer = typeof Promise=='function' ? Promise.resolve().then.bind(Promise.r */ export function enqueueRender(c) { if (!c._dirty && (c._dirty = true) && q.push(c) === 1) { - (Component.debounce || defer)(process); + (options.debounceRendering || defer)(process); } } From b4214608fa69c49d190ec076894c7d8872c17b93 Mon Sep 17 00:00:00 2001 From: Jason Miller Date: Mon, 4 Mar 2019 18:14:51 -0500 Subject: [PATCH 2/2] fix tests for options.debounceRendering --- test/_util/helpers.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/_util/helpers.js b/test/_util/helpers.js index 4200b938b3..1457e56919 100644 --- a/test/_util/helpers.js +++ b/test/_util/helpers.js @@ -20,8 +20,8 @@ export function setupScratch() { * @returns {() => void} */ export function setupRerender() { - Component.__test__previousDebounce = Component.debounce; - Component.debounce = cb => Component.__test__drainQueue = cb; + Component.__test__previousDebounce = options.debounceRendering; + options.debounceRendering = cb => Component.__test__drainQueue = cb; return () => Component.__test__drainQueue && Component.__test__drainQueue(); } @@ -55,7 +55,7 @@ export function teardown(scratch) { } if (typeof Component.__test__previousDebounce !== 'undefined') { - Component.debounce = Component.__test__previousDebounce; + options.debounceRendering = Component.__test__previousDebounce; delete Component.__test__previousDebounce; }