Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added spoken form to API #46

Merged
merged 2 commits into from
Aug 1, 2021
Merged

Added spoken form to API #46

merged 2 commits into from
Aug 1, 2021

Conversation

AndreasArvidsson
Copy link
Member

No description provided.

@AndreasArvidsson AndreasArvidsson changed the title Added spoken command to API Added spoken form to API Aug 1, 2021
@@ -68,8 +77,10 @@ def cursorless_multiple_target_command(
):
"""Execute multi-target cursorless command"""
args = list(filter(lambda x: x is not NotSet, [arg1, arg2, arg3]))
spoken_form = " ".join(last_phrase["phrase"])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to check, if I say "disk take air", this won't pick up the initial "disk" right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will. So we are going to have some discipline when we do the test cases.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. Ok I'm gonna approve this one just so you're not blocked on adding tests to your other PRs but not sure I'm in love with passing through the whole command to every cursorless command. Let's discuss later

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I think we could improve this. Just unsure of the best solution right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants