Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added actions: replace, phones, formatter, find #33

Merged
merged 4 commits into from
Aug 1, 2021
Merged

Added actions: replace, phones, formatter, find #33

merged 4 commits into from
Aug 1, 2021

Conversation

AndreasArvidsson
Copy link
Member

@AndreasArvidsson AndreasArvidsson commented Jul 23, 2021 •
edited
Loading

  • Added action replace
    • With user text, formatted text or numeric range
  • Added action phones
  • Added action reformat
  • Added action paste
  • Rename action pree to pre
  • Disabled modifiers above and below

Necessary actions are implemented in community repository.
talonhub/community#518

@AndreasArvidsson AndreasArvidsson changed the title Added actions: replace, phones, formatter Added actions: replace, phones, formatter, paste Jul 24, 2021
@AndreasArvidsson AndreasArvidsson linked an issue Jul 24, 2021 that may be closed by this pull request
Try “pre” instead of “pree” #22
Closed
@AndreasArvidsson AndreasArvidsson changed the base branch from master to develop July 24, 2021 18:29
@AndreasArvidsson AndreasArvidsson marked this pull request as draft July 24, 2021 18:34
@AndreasArvidsson AndreasArvidsson marked this pull request as ready for review July 24, 2021 18:34
pokey
pokey reviewed Jul 27, 2021
View reviewed changes
Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok overall looks good! Left some comments

.vscode/settings.json Outdated Show resolved Hide resolved
src/actions/actions.py Outdated Show resolved Hide resolved
src/actions/actions.py Outdated Show resolved Hide resolved
src/actions/find.py Outdated Show resolved Hide resolved
src/actions/get_texts.py Outdated Show resolved Hide resolved
src/actions/reformat.py Show resolved Hide resolved
src/modifiers/position.py Outdated Show resolved Hide resolved
src/modifiers/selection_type.py Outdated Show resolved Hide resolved
src/actions/replace.py Outdated Show resolved Hide resolved
src/actions/replace.py Show resolved Hide resolved
@AndreasArvidsson AndreasArvidsson changed the title Added actions: replace, phones, formatter, paste Added actions: replace, phones, formatter, find Jul 28, 2021
@AndreasArvidsson
Copy link
Member Author

Necessary actions are implemented in community repository.
talonhub/community#518

@AndreasArvidsson AndreasArvidsson changed the base branch from develop to andreas_develop August 1, 2021 12:42
@AndreasArvidsson AndreasArvidsson merged commit 718c957 into andreas_develop Aug 1, 2021
@AndreasArvidsson AndreasArvidsson deleted the replace branch August 1, 2021 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pokey pokey pokey left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Try “pre” instead of “pree”
2 participants
@AndreasArvidsson @pokey