Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid updating CSV on error reading VSCode settings #137

Merged
merged 3 commits into from
Dec 17, 2021
Merged

Avoid updating CSV on error reading VSCode settings #137

merged 3 commits into from
Dec 17, 2021

Conversation

pokey
Copy link
Member

@pokey pokey commented Dec 17, 2021 •
edited
Loading

Closes #134

@pokey pokey linked an issue Dec 17, 2021 that may be closed by this pull request
Don't write hat_styles.csv if there was error reading VSCode settings #134
Closed
1 task
AndreasArvidsson
AndreasArvidsson approved these changes Dec 17, 2021
View reviewed changes
Copy link
Member

@AndreasArvidsson AndreasArvidsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix. This has really bitten me sometimes

@AndreasArvidsson AndreasArvidsson merged commit 1ff4f66 into develop Dec 17, 2021
@AndreasArvidsson AndreasArvidsson deleted the pokey-no-update-csv-on-error branch December 17, 2021 10:57
@pokey pokey mentioned this pull request Dec 17, 2021
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreasArvidsson AndreasArvidsson AndreasArvidsson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't write hat_styles.csv if there was error reading VSCode settings
2 participants
@pokey @AndreasArvidsson