Added identity modifier. Added head tail modifier to csv #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pokey
reviewed
Dec 2, 2021
Co-authored-by: Pokey Rule <pokey.rule@gmail.com>
Co-authored-by: Pokey Rule <pokey.rule@gmail.com>
|
All updated. |
pokey
previously approved these changes
Dec 2, 2021
Comment on lines
+16
to
+17
| HeadTail("head", "extendThroughStartOf", "head"), | ||
| HeadTail("tail", "extendThroughEndOf", "tail"), |
There was a problem hiding this comment.
Hmm. Yeah probably path of least resistance for now rather than having to mess around extension-side
I think it's fairly clear. |
pokey
approved these changes
Dec 2, 2021
pokey
added a commit
that referenced
this pull request
Dec 13, 2021
* Added identity modifier. Added head tail modifier to csv * Update src/modifiers/identity.py Co-authored-by: Pokey Rule <pokey.rule@gmail.com> * Update src/modifiers/modifiers.py Co-authored-by: Pokey Rule <pokey.rule@gmail.com> * Changed identifier on head tail * Update src/modifiers/identity.py Co-authored-by: Pokey Rule <pokey.rule@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bring line air to just batAlso added head/tail to csv.
We probably need to expand the identifiers in the csv a bit.