Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of modulo line numbers #105

Merged
merged 5 commits into from
Nov 27, 2021
Merged

Implementation of modulo line numbers #105

merged 5 commits into from
Nov 27, 2021

Conversation

AndreasArvidsson
Copy link
Member

@AndreasArvidsson AndreasArvidsson commented Nov 25, 2021

take row 15 => will select 15/115/215/...

pokey
pokey previously approved these changes Nov 27, 2021
Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really nice. I left a couple minor comments but otherwise looks great

src/marks/lines_number.py Outdated Show resolved Hide resolved
src/marks/mark.py Outdated Show resolved Hide resolved
Co-authored-by: Pokey Rule <pokey.rule@gmail.com>
AndreasArvidsson and others added 2 commits November 27, 2021 15:35
Co-authored-by: Pokey Rule <pokey.rule@gmail.com>
@pokey pokey merged commit c86907f into develop Nov 27, 2021
@pokey pokey deleted the modulo_line branch November 27, 2021 16:11
pokey added a commit that referenced this pull request Dec 13, 2021
* Implementation of modulo line numbers

* Cleanup line numbers

* Update src/marks/lines_number.py

Co-authored-by: Pokey Rule <pokey.rule@gmail.com>

* clean up identifier

* Update src/marks/mark.py

Co-authored-by: Pokey Rule <pokey.rule@gmail.com>

Co-authored-by: Pokey Rule <pokey.rule@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants