Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UNKNOWN distribution type which allows reading properties of unsupported distributions. Examples seen in stochastic process mining such as the
StochasticPetriNets
plugin in ProM include GAUSSIAN_KERNEL, DETERMINISTIC, GAMMA and HISTOGRAM. It is useful to be still be able to read weights, priorities, and so on in pm4py even if full support is not available.An example snippet produced from running that SPN plugin on the
BPIC2013_closed.xes
reference log:I don't expect pm4py to drop everything and start supporting all distribution types. I'm not sure if it's even a good idea. But since there doesn't seem to be a central standard for extended stochastic net distributions, it is definitely useful if pm4py doesn't throw away what properties do exist and can be read. In my current use case, I don't need to perform any direct simulation, but I do need to be able to describe the net in question.
This is my first PR for pm4py. I am very open to feedback about alternative ways to do this, or pointers if I've just misunderstood the current capabilities of pm4py.
I ran the unit tests before and after. 4/326 failed both before and after. The failing tests all appear to be related to extensions outside core not affected by this patch. The SPN importer doesn't seem to have specific coverage, and that isn't changed by this patch.
Abbreviated test output (can share full on request)
Ran 326 tests in 28.805s
FAILED (errors=4)
Cheers
Adam