Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixup.ts needs to do more work on .cmake files #133

Open
jhheider opened this issue Jun 14, 2023 · 1 comment
Open

fixup.ts needs to do more work on .cmake files #133

jhheider opened this issue Jun 14, 2023 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@jhheider
Copy link
Contributor

Of interest is their encoding full versions for deps:

CMake Error in CMakeLists.txt:
  Imported target "sodium" includes non-existent path

    "/Users/jacob/.tea/libsodium.org/v1.0.18/include"

  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:

  * The path was deleted, renamed, or moved to another location.

  * An install or uninstall procedure did not complete successfully.

  * The installation package was faulty and references files it does not
  provide.

fixup.ts should truncate those to e.g. v1 for proper compatibility.

@jhheider jhheider added bug Something isn't working good first issue Good for newcomers labels Jun 14, 2023
@jhheider
Copy link
Contributor Author

jhheider commented Oct 2, 2023

current state-of-the-art in manual fixes looks like this:

    - run: |
        sed -E -i.bak \
          -e "s:{{pkgx.prefix}}:\$\{_IMPORT_PREFIX\}/../../..:g" \
          -e '/^  INTERFACE_INCLUDE_DIRECTORIES/ s|/v([0-9]+)(\.[0-9]+)*[a-z]?/include|/v\1/include|g' \
          -e '/^  INTERFACE_LINK_LIBRARIES/ s|/v([0-9]+)(\.[0-9]+)*[a-z]?/lib|/v\1/lib|g' \
        wangle-targets.cmake
        rm wangle-targets.cmake.bak
      working-directory: "{{prefix}}/lib/cmake/wangle"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant