Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.cmake files need more touchups #121

Open
jhheider opened this issue May 22, 2023 · 0 comments
Open

.cmake files need more touchups #121

jhheider opened this issue May 22, 2023 · 0 comments
Labels
good first issue Good for newcomers

Comments

@jhheider
Copy link
Contributor

See facebook.com/folly:

tea $ rg double-conv ~/.tea/facebook.com/folly/v2023/lib/cmake/folly 
/root/.tea/facebook.com/folly/v2023/lib/cmake/folly/folly-targets.cmake
70:  INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/../../../boost.org/v1.82.0/include;${_IMPORT_PREFIX}/../../../google.com/double-conversion/v3.3.0/include;${_IMPORT_PREFIX}/../../../gflags.github.io/v2.2.2/include;${_IMPORT_PREFIX}/../../../google.com/glog/v0.6.0/include;${_IMPORT_PREFIX}/../../../libevent.org/v2.1.12/include;${_IMPORT_PREFIX}/../../../zlib.net/v1.2.13/include;${_IMPORT_PREFIX}/../../../openssl.org/v1.1.1t/include;${_IMPORT_PREFIX}/../../../sourceware.org/bzip2/v1.0.8/include;${_IMPORT_PREFIX}/../../../lz4.org/v1.9.4/include;${_IMPORT_PREFIX}/../../../facebook.com/zstd/v1.5.5/include;${_IMPORT_PREFIX}/../../../google.github.io/snappy/v1.1.10/include;${_IMPORT_PREFIX}/include"
71:  INTERFACE_LINK_LIBRARIES "fmt::fmt;Threads::Threads;Boost::context;Boost::filesystem;Boost::program_options;Boost::regex;Boost::system;Boost::thread;${_IMPORT_PREFIX}/../../../google.com/double-conversion/v3.3.0/lib/libdouble-conversion.so;gflags_shared;${_IMPORT_PREFIX}/../../../google.com/glog/v0.6.0/lib/libglog.so;${_IMPORT_PREFIX}/../../../libevent.org/v2.1.12/lib/libevent.so;${_IMPORT_PREFIX}/../../../zlib.net/v1.2.13/lib/libz.so;${_IMPORT_PREFIX}/../../../openssl.org/v1.1.1t/lib/libssl.so;${_IMPORT_PREFIX}/../../../openssl.org/v1.1.1t/lib/libcrypto.so;${_IMPORT_PREFIX}/../../../sourceware.org/bzip2/v1.0.8/lib/libbz2.so;${_IMPORT_PREFIX}/../../../lz4.org/v1.9.4/lib/liblz4.so;${_IMPORT_PREFIX}/../../../facebook.com/zstd/v1.5.5/lib/libzstd.so;${_IMPORT_PREFIX}/../../../google.github.io/snappy/v1.1.10/lib/libsnappy.so;dl;atomic;stdc++fs"

Our fixup.ts should do the same thing fix-machos/fix-elf do in terms of locating our software and shortening it to use v{{version.major}} to prevent hard-locking version dependencies. So far, this has only bitten us in facebook code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant