Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3OpenRead ignores the mode of 'r' opens always in 'rb' #74

Closed
vinayan3 opened this issue Jun 2, 2016 · 2 comments
Closed

S3OpenRead ignores the mode of 'r' opens always in 'rb' #74

vinayan3 opened this issue Jun 2, 2016 · 2 comments
Labels

Comments

@vinayan3
Copy link

vinayan3 commented Jun 2, 2016

The S3OpenRead always returns data as bytes in Python 3 which breaks things expecting str. The S3OpenRead needs to respect 'r' instead of returning everything as bytes.

@appierys
Copy link

appierys commented Dec 1, 2017

It appears that now smart_open supports 'r' mode in 1.5.4?
However, I found that the speed of reading files drops significantly after smart_open 1.5.4.

For smart_open 1.5.3, the speed is:
2868923it [01:05, 43987.90it/s]

while smart_open 1.5.4 is:
41588it [01:35, 434.05it/s]
for the same S3 file.

@menshikh-iv
Copy link
Contributor

Already fixed (doesn't reproduce with current master fbc82cc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants