From 052f6b130f53ad50f571b81d4d468b0b0026c2fd Mon Sep 17 00:00:00 2001
From: Ondrej Mirtes <ondrej@mirtes.cz>
Date: Sun, 8 Sep 2024 08:52:42 +0200
Subject: [PATCH] Fix internal error

---
 src/Type/Php/RegexArrayShapeMatcher.php       |  4 +-
 .../Analyser/AnalyserIntegrationTest.php      |  6 +++
 tests/PHPStan/Analyser/data/bug-11649.php     | 38 +++++++++++++++++++
 3 files changed, 46 insertions(+), 2 deletions(-)
 create mode 100644 tests/PHPStan/Analyser/data/bug-11649.php

diff --git a/src/Type/Php/RegexArrayShapeMatcher.php b/src/Type/Php/RegexArrayShapeMatcher.php
index fb94b88ab0..63e44b3ea2 100644
--- a/src/Type/Php/RegexArrayShapeMatcher.php
+++ b/src/Type/Php/RegexArrayShapeMatcher.php
@@ -157,7 +157,7 @@ private function matchRegex(string $regex, ?int $flags, TrinaryLogic $wasMatched
 			if (!$this->containsUnmatchedAsNull($flags, $matchesAll)) {
 				// positive match has a subject but not any capturing group
 				$combiType = TypeCombinator::union(
-					new ConstantArrayType([new ConstantIntegerType(0)], [$this->createSubjectValueType($flags, $matchesAll)], [0], [], true),
+					new ConstantArrayType([new ConstantIntegerType(0)], [$this->createSubjectValueType($flags, $matchesAll)], [1], [], true),
 					$combiType,
 				);
 			}
@@ -222,7 +222,7 @@ private function matchRegex(string $regex, ?int $flags, TrinaryLogic $wasMatched
 				)
 			) {
 				// positive match has a subject but not any capturing group
-				$combiTypes[] = new ConstantArrayType([new ConstantIntegerType(0)], [$this->createSubjectValueType($flags, $matchesAll)], [0], [], true);
+				$combiTypes[] = new ConstantArrayType([new ConstantIntegerType(0)], [$this->createSubjectValueType($flags, $matchesAll)], [1], [], true);
 			}
 
 			return TypeCombinator::union(...$combiTypes);
diff --git a/tests/PHPStan/Analyser/AnalyserIntegrationTest.php b/tests/PHPStan/Analyser/AnalyserIntegrationTest.php
index 236c066b72..c98129fc99 100644
--- a/tests/PHPStan/Analyser/AnalyserIntegrationTest.php
+++ b/tests/PHPStan/Analyser/AnalyserIntegrationTest.php
@@ -312,6 +312,12 @@ public function testBug3309(): void
 		$this->assertNoErrors($errors);
 	}
 
+	public function testBug11649(): void
+	{
+		$errors = $this->runAnalyse(__DIR__ . '/data/bug-11649.php');
+		$this->assertNoErrors($errors);
+	}
+
 	public function testBug6872(): void
 	{
 		if (PHP_VERSION_ID < 80000) {
diff --git a/tests/PHPStan/Analyser/data/bug-11649.php b/tests/PHPStan/Analyser/data/bug-11649.php
new file mode 100644
index 0000000000..8f31554f43
--- /dev/null
+++ b/tests/PHPStan/Analyser/data/bug-11649.php
@@ -0,0 +1,38 @@
+<?php
+
+namespace Bug11649;
+
+use DateTime;
+
+class Date
+{
+	/**
+	 * Characters used in formats accepted by date()
+	 */
+	protected const DATE_FORMAT_CHARACTERS = 'AaBcDdeFgGHhIijlLMmnNoOpPrsSTtUuvWwyYzZ';
+
+	/**
+	 * Regex used to parse formats accepted by date()
+	 */
+	protected const DATE_FORMAT_REGEX = '/(?P<escaped>(?:\\\[A-Za-z])+)|[' . self::DATE_FORMAT_CHARACTERS . ']|(?P<invalid>[A-Za-z])/';
+
+	/**
+	 * Formats a DateTime object using the current translation for weekdays and months
+	 * @param mixed $translation
+	 */
+	public static function formatDateTime(DateTime $dateTime, string $format, ?string $language , $translation): ?string
+	{
+		return preg_replace_callback(
+			self::DATE_FORMAT_REGEX,
+			fn(array $matches): string => match ($matches[0]) {
+				'M'     => $translation->getStrings('date.months.short')[$dateTime->format('n') - 1],
+				'F'     => $translation->getStrings('date.months.long')[$dateTime->format('n') - 1],
+				'D'     => $translation->getStrings('date.weekdays.short')[(int) $dateTime->format('w')],
+				'l'     => $translation->getStrings('date.weekdays.long')[(int) $dateTime->format('w')],
+				'r'     => static::formatDateTime($dateTime, DateTime::RFC2822, null, $translation),
+				default => $dateTime->format($matches[1] ?? $matches[0])
+			},
+			$format
+		);
+	}
+}