Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: execute static analysis, fuzzing, and dependency scanner on pull request target #591

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

richardapeters
Copy link
Collaborator

No description provided.

@richardapeters richardapeters requested a review from a team as a code owner March 19, 2024 10:19
Copy link
Contributor

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 12 0 0.07s
✅ CPP clang-format 951 2 0 7.38s
✅ DOCKERFILE hadolint 2 0 0.11s
✅ JSON eslint-plugin-jsonc 9 0 0 3.34s
✅ JSON jsonlint 9 0 0.2s
✅ JSON prettier 9 0 0 0.74s
⚠️ MARKDOWN markdownlint 6 0 4 1.61s
⚠️ MARKDOWN markdown-link-check 6 2 48.79s
✅ MARKDOWN markdown-table-formatter 6 0 0 0.37s
✅ REPOSITORY checkov yes no 21.28s
✅ REPOSITORY git_diff yes no 0.05s
✅ REPOSITORY grype yes no 15.94s
✅ REPOSITORY secretlint yes no 8.86s
✅ REPOSITORY trivy yes no 12.15s
✅ REPOSITORY trivy-sbom yes no 1.08s
✅ REPOSITORY trufflehog yes no 5.61s
⚠️ SPELL lychee 137 2 2.4s
⚠️ YAML prettier 22 0 1 1.23s
✅ YAML v8r 22 0 10.8s
✅ YAML yamllint 22 0 0.7s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link
Member

@rjaegers rjaegers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the workflows changed in this PR don't actually run in the context of this PR anymore.

Copy link
Contributor

@daantimmer daantimmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure we want this?

pull_request_target event grants workflows triggered by pull requests from forks access to repository secrets and a read/write GITHUB_TOKEN. That is inherently risky if the workflow inadvertently exposes these secrets or allows for unauthorized modifications to the repository.
https://stackoverflow.com/a/74959635

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants