Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OnTick callback issue in ClickerManager #3

Open
supratikbanerjee opened this issue Nov 13, 2022 · 0 comments
Open

OnTick callback issue in ClickerManager #3

supratikbanerjee opened this issue Nov 13, 2022 · 0 comments

Comments

@supratikbanerjee
Copy link

public void Tick()
{
    bool updated = false;
    foreach (Currency currency in Config.Currencies)
    {
        float amount = PerSecondAmount(currency);

        updated = UpdateTotal(currency, amount);
    }

    UpdateUnlocks();
    if (updated)
    {
        OnTick.Invoke();
    }
}

Isn't the updated bool incorrectly assigned in the loop? If the last currency in an iteration isn't updated, it'll render no calls to OnTick events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant