Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for setting 'migration.6_to_7.enabled' #244

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

skrussell
Copy link

The title says it all really. I needed to be able to set the 'migration.6_to_7.enabled' config parameter, but couldn't find a way to do it with the existing module. I've added it as a simple Boolean option, defaulted to false, and it works for me.

@pcfens
Copy link
Owner

pcfens commented Feb 25, 2020

Thanks for the contribution. If I'm reading the docs correctly, that parameter only has to be set on one machine so the schema is updated in ES. If that's the case then I'm not sure it'd be something that we'd want to apply to every machine (just 1 to update the schema?). We also don't manage the initial schema setup, so I don't know if we want to manage upgrades but not initial setup.

We don't ship directly to ES, so I may be misunderstanding this entirely too.

@skrussell
Copy link
Author

If I'm completely honest, I am not too sure what this setting actually does. I am simply re-implementing a puppetised version (for eventual production usage) of an already working development environment. Removing the setting causes the following error(s) on our logstash server: Detected a 6.x and above cluster: the 'type' event field won't be used to determine the document _type {:es_version=>7}, so for us it is definitely required.

Regardless though, it is definitely a valid setting within the filebeat.yml file, but until I made these changes, I could not find a way to set it using this module. If you're not overly keen on the method of implementation (i.e. the boolean flag), perhaps a more generic way of adding any additional top level setting would be preferred?

Feature release 4.9.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants